Fix stale SecretHashes on nodeset status after node removal#1849
Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom Apr 14, 2026
Merged
Conversation
OpenStackControlPlane CRD Size Report
Threshold reference
|
When a node is removed from a nodeset and a full deployment (no ServicesOverride) succeeds, overwrite the nodeset's SecretHashes with the deployment's hashes instead of merging. This drops stale TLS cert secret hash entries for the removed node. Partial deployments (with ServicesOverride) continue to merge additively to preserve hashes from other deployments. Change-Id: I12abffa18af63b14630f80f5a0e6235158f4a9ef Signed-off-by: rabi <ramishra@redhat.com>
slagle
approved these changes
Apr 13, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rabi, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
openshift-merge-bot
bot
merged commit c0e6251
into
openstack-k8s-operators:main
8 checks passed
Contributor
Author
|
/cherry-pick 18.0-fr5 |
|
@rabi: new pull request created: #1886 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a node is removed from a nodeset and a full deployment (no ServicesOverride) succeeds, overwrite the nodeset's SecretHashes with the deployment's hashes instead of merging. This drops stale TLS cert secret hash entries for the removed node. Partial deployments (with ServicesOverride) continue to merge additively to preserve hashes from other deployments.
jira: OSPRH-27533